fix(ENG-9886): deprecated false positive #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-9886 Using useSearchParams will warn with the wrong message
The following warning is thrown: |
EvanBacon
requested changes
Aug 28, 2023
|
Any updates here? This is the cause of the false positive warning that is bugging a lot of people on the latest Expo Router (2.0.8) and latest Expo SDK (49) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix ENG-9886.
Execution
useDeprecatedis a hook I added a while ago to easily log deprecated warnings once, and handle edge cases such as preventing multiple warnings during SSR & CI environment. I added code comments to explain its parameters.The issue was the
guardhas a default value oftrue. So if you passundefined, instead of usingundefinedit will switch totrue. This is counter intuitive and a sign this hook needs to be refactored.I like the guard having a truthy default, because you can simply write
useDeprecated(<message>)with no guard. Maybe we need to split it into two functions?